Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings after updating to Ruby 2.7 #69

Closed
sjovanelly opened this issue Aug 21, 2020 · 3 comments
Closed

Warnings after updating to Ruby 2.7 #69

sjovanelly opened this issue Aug 21, 2020 · 3 comments

Comments

@sjovanelly
Copy link

Using the batch loader is giving me some warnings now with 2.7.1.

rvm/gems/ruby-2.7.1/gems/batch-loader-1.5.0/lib/batch_loader/graphql.rb:58: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

Looks like this method needs a tweak...
def batch(*args, &block)
@batch_loader.batch(*args, &block)
self
end

More notes on potential fix.
https://bloggie.io/@kinopyo/how-to-fix-ruby-2-7-warning-using-the-last-argument-as-keyword-parameters-is-deprecated

@ghost
Copy link

ghost commented Sep 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@ghost ghost added the stale Inactive label Sep 4, 2020
@ghost ghost closed this as completed Sep 11, 2020
@carrabi
Copy link

carrabi commented Sep 14, 2020

Any update on this? I'm experiencing the same issue as @sjovanelly

@ghost ghost removed the stale Inactive label Sep 14, 2020
@dub-squared
Copy link
Contributor

This should be resolved with the merge of #71

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants