New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🔨common]: Get rid of the hardcoded domain #336

Open

yadamskaya opened this issue Jun 9, 2022 · 1 comment

Assignees

Labels

Collaborator

yadamskaya commented Jun 9, 2022

Now it looks like this:

We should be able to get the domain from the settings.

yadamskaya added enhancement needs assignee labels

AlexanderBazukevich self-assigned this

yadamskaya removed the needs assignee label

Contributor

ala-n commented Sep 25, 2023 •

edited

Loading

Note: please be aware of the latest workflow updates.
The actual domain is now passed by the environment variable SITE_BASE_URL

See details in the workflow file
https://github.com/exadel-inc/ui-playground/blob/main/.github/workflows/pages.yaml

Please also take a look at the following files:

https://github.com/exadel-inc/ui-playground/blob/main/pages/views/_data/env.js
https://github.com/exadel-inc/ui-playground/blob/main/pages/views/_data/site.json
Bot of them could be considered as a legacy approach.

Please use the truthful config module with the resolved configuration variables + global data registration hook for 11ty
See

https://github.com/exadel-inc/esl/blob/main/pages/11ty/env.config.js
https://github.com/exadel-inc/esl/blob/main/pages/11ty/site.config.js
of ESL library as it developed with the same standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment