Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔨common]: update the detail data of uip:configchange event #407

Open
yadamskaya opened this issue Sep 22, 2022 · 0 comments
Open

[🔨common]: update the detail data of uip:configchange event #407

yadamskaya opened this issue Sep 22, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@yadamskaya
Copy link
Collaborator

The concern is that we dispatch the uip:configchange event with not processed data: name + value
The recommendation is to send processed and limited data.
Not:

{
  detail: {
     attribute: 'settings-collapsed',
     value: null
  }
}

But:

{
  detail: {
     config: 'settings-collapsed',
     value: false
  }
}

Or something like that

Or even simpler: dispatch the type of change but access the current value from the root directly.

@yadamskaya yadamskaya added enhancement New feature or request needs assignee labels Sep 22, 2022
@ala-n ala-n self-assigned this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants