Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀uip-preview] make able to pass resizable attribute feature from snippet level #748

Open
ala-n opened this issue May 13, 2024 · 0 comments
Assignees
Milestone

Comments

@ala-n
Copy link
Contributor

ala-n commented May 13, 2024

As a UIP consumer, I want to be able to use both resizable/non-resizable examples in bounds of single UIP instance.

Proposed to add resizable as a feature of snippet

<script type="text/html"
              label="Some Example"
              uip-snippet
              uip-snippet-resiable>

The resizable attribute of uip-preview can be hadeled using any of mentioned options (@yadamskaya correct me if you prefer one):

  • A. Simply remove and do not support on element level
  • B. Support and use with priority
    JS is not necessary required for that option: just use marker value for that property in case it was set via snippet
    E.g. <uip-preview resizable> - always resizable, ignores snippet
    <uip-preview resizable="snippet"> - dynamically set by UIP code from snippet in case resizable was not presented with different value but passed as an option of snippet (will be removed if the next snippet is not resizable)

Note: please make sure in case resizable option was removed the inline size of preview area is flushed (as right now we will have a dynamic behaviour under resizable attribute)

@ala-n ala-n added this to the UIP 2.0.0 milestone May 13, 2024
@yadamskaya yadamskaya self-assigned this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants