Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLC Deployer: Add timeout option to CLI #52

Open
Tracked by #42
ckunki opened this issue Aug 14, 2024 · 3 comments · May be fixed by #57
Open
Tracked by #42

SLC Deployer: Add timeout option to CLI #52

ckunki opened this issue Aug 14, 2024 · 3 comments · May be fixed by #57
Assignees
@tkilias @ckunki
Labels
feature Product feature

Comments

@ckunki
Copy link
Contributor

ckunki commented Aug 14, 2024 •
edited
Loading

In the scope of ticket #50 a new ExtractValidator has been implemented.

The current ticket requests adding options to the CLI so that an interactive user can control the timeout duration.

Proposal:

@click.option('--extract-timeout-minutes', type=int, default=10)

Open question:

  • Should the CLI specify a default-callback?
  • Should the CLI enable to select a callback?
@ckunki ckunki added the feature Product feature label Aug 14, 2024
@ckunki ckunki self-assigned this Aug 14, 2024
This was referenced Aug 14, 2024
Closed
Closed
Open
@ahsimb
Copy link
Collaborator

ahsimb commented Aug 16, 2024

How would interactive users know what the timeout value should be?
I don't think this option is necessary. It will just clog the documentation.

@ckunki ckunki linked a pull request Aug 20, 2024 that will close this issue
Open
@tkilias
Copy link
Collaborator

tkilias commented Sep 12, 2024

@ahsimb this option makes actually sense, because the time to wait depends on a lot of factors. And, not all of them we have under control or can detect.

Factors

  • Size of SLC
  • Files in SLC
  • Nodes in Cluster
  • type of BucketFS (SaaS or on-prem)
  • hardware (CPU speed, disk speed, network speed)

@tkilias tkilias self-assigned this Sep 13, 2024
@ckunki
Copy link
Contributor Author

ckunki commented Sep 13, 2024

I agree to both comments: this option makes sense in my eyes, but still the users won't know what the timeout value should be in advance. Bad situation.

I personally would prefer having a way to adjust the timeout than having no way.

ckunki added a commit that referenced this issue Sep 23, 2024
@ckunki
Merge branch 'main' into feature/#52-Added_timeout_options_for_SLC_de…
fb7c804 
…ployer_to_CLI
ckunki added a commit that referenced this issue Oct 7, 2024
@ckunki
Merge branch 'main' into feature/#52-Added_timeout_options_for_SLC_de…
6bcc7c5 
…ployer_to_CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkilias tkilias

@ckunki ckunki

Labels
feature Product feature
Projects
None yet
Milestone
No milestone
3 participants
@tkilias @ahsimb @ckunki