-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using Sphinx 4 #338
Comments
Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗 |
Indeed - the next step to get this is to update the MyST Parser dependency, which will bring support for Sphinx 4 when that happens (https://github.com/executablebooks/MyST-Parser/blob/master/CHANGELOG.md#0150---2021-06-13). There might need to be some other changes too though. |
Just checking in. Is there anything we can do to help move this forward? |
Any progress? 👀 |
Well myst-parser is updated, so this should now work in principle |
Cool. I will have a try and give some feedback asap. |
Note we would want |
A notable potential change, would be to set |
INFO: pip is looking at multiple versions of sphinx-togglebutton to determine which version is compatible with other requirements. This could take a while.
INFO: This is taking longer than usual. You might need to provide the dependency resolver with stricter constraints to reduce runtime. If you want to abort this run, you can press Ctrl + C to do so. To improve how pip performs, tell us what happened here: https://pip.pypa.io/surveys/backtracking When I add
|
Line 51 in c98d432
sphinx>=2,<4
|
oh no what I mean is that it should work with the change to myst-nb, to |
but yeh it won't work yet for the current published version |
any chance that @mmcky or @AakashGfude would be able to tackle this one? If we can get MyST-NB to Sphinx 4, then we can also get sphinx-book-theme to Sphinx 4, and then Jupyter Book to Sphinx 4! |
@choldgraf yup -- I added this to the |
Summary
Right now
sphinx>=2,<4
in setup.cfg makes it impossible to usemyst-nb
with Sphinx 4.myst-parser
upgraded to Sphinx 4 recently executablebooks/MyST-Parser#390.Tasks to complete
<5
herehttps://github.com/executablebooks/MyST-NB/blob/master/setup.cfg#L51
and bump myst-parser to the latest version here:
https://github.com/executablebooks/MyST-NB/blob/master/setup.cfg#L47
The text was updated successfully, but these errors were encountered: