Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always “config changed ('nb_render_image_options')” #605

Closed
flying-sheep opened this issue Jun 4, 2024 · 1 comment
Closed

Always “config changed ('nb_render_image_options')” #605

flying-sheep opened this issue Jun 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@flying-sheep
Copy link
Contributor

Describe the bug

context
When I run sphinx, it always invalidates the config.

I assume that’s because of a bug that (I introdoced and that) would be fixed in #599

expectation
I expected Sphinx’ cache to work

bug
But instead Sphinx never realizes that nb_render_image_options is unchanges

updating environment: [config changed ('nb_render_image_options')] 359 added, 0 changed, 0 removed

problem
This is a problem because local builds should be fast

Reproduce the bug

Build documentation with width/height metadata for an image and myst-nb

List your environment

myst-nb==1.1.0
@flying-sheep flying-sheep added the bug Something isn't working label Jun 4, 2024
@flying-sheep flying-sheep mentioned this issue Jun 4, 2024
Closed
@flying-sheep
Copy link
Contributor Author

Fixed by #609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix image metadata being used in wrong cell flying-sheep/MyST-NB
1 participant
@flying-sheep