Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sqlalchemy v2 style API #71

Open
chrisjsewell opened this issue Jul 29, 2021 · 1 comment
Open

Use sqlalchemy v2 style API #71

chrisjsewell opened this issue Jul 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@chrisjsewell
Copy link
Member

Now supported with 1.4, see https://docs.sqlalchemy.org/en/14/changelog/migration_14.html#orm-query-is-internally-unified-with-select-update-delete-2-0-style-execution-available

I think maybesession.query needs to be changed to select?
@chrisjsewell chrisjsewell added the enhancement New feature or request label Jul 29, 2021
@chrisjsewell
Copy link
Member Author

also use WAL mode for connections, which improves concurrency: https://sqlite.org/wal.html
See e.g. https://github.com/aiidateam/disk-objectstore/blob/65a3e5d9b8c95d7f9a7309a01f8be68bc11be1bd/disk_objectstore/database.py#L34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisjsewell