-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap 5 #332
Comments
Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗 |
For sure - though right now we are inheriting from there pydata theme, so unless that changes we will get whatever bootstrap version from them |
Thanks for the prompt response - I wasn’t aware of this dependency. (I thought the book theme was just inspired by pydata’s.) On a side note I am primarily concerned with properly displaying math content on both mobile and desktop. The pydata theme lends itself to some - in my opinion - questionable practices that reverberate on math elements (e.g., overflow). I was happy to see that it was not the case in the book theme.
However there are still some minor issues such as word wrap (e.g., see [1] on mobile) that I believe are amenable to being solved by Bootstrap [2]. [1] https://sphinx-book-theme.readthedocs.io/en/latest/reference/demo.html#id10 |
I'm pretty sure this would be considered a bug that they'd like to fix. :) |
FWIW, you don't need to upgrade to Bootstrap 5 for this. It's literally setting:
Which, we can do here as well. I'm pretty sure the main thing that'll have these issues is links. |
Indeed it would be great to see this overflow fizz on the pydata theme and the reword fix here or in the pydata theme 🙂 |
I know it’s early to point out but I figured it’d be interesting to open an issue to track upcoming development on supporting or not Bootstrap 5 [1, 2].
[1] https://blog.getbootstrap.com/2021/05/05/bootstrap-5
[2] https://getbootstrap.com/docs/5.0/migration
The text was updated successfully, but these errors were encountered: