Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme CSS update is needed for Sphinx 4.0.1 #335

Closed
outoftardis opened this issue May 19, 2021 · 2 comments
Closed

Theme CSS update is needed for Sphinx 4.0.1 #335

outoftardis opened this issue May 19, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@outoftardis
Copy link

outoftardis commented May 19, 2021

Describe the bug

After upgrading Sphinx to version 4.0.1, I've noticed a change in styles. In this issue in michaeljones/breathe repository I was told that it is not a bug on Sphinx/breathe side but rather an intentional change in the new version of Sphinx, and that css should be fixed on the theme side.

Here's what the breathe output looks like with Sphinx 4.0.1 and sphinx-book-theme 0.1.0. If you compare it with the output produced with the earlier version of Sphinx, you'll see that all the code highlighting is missing:

image

Expected behavior

With Sphinx==3.5.4 and sphinx-book-theme 0.1.0 the output looks like this:

image

To reproduce

The example (rst/header) is taken directly from the breathe documentation.

Environment

  • Python Version: 3.6.9
  • Operating System: Ubuntu
  • breathe==4.30.0
  • sphinx-book-theme==0.1.0
@outoftardis outoftardis added the bug Something isn't working label May 19, 2021
@welcome
Copy link

welcome bot commented May 19, 2021

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@choldgraf
Copy link
Member

this one is resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants