-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anchor links have incorrect offset from top of screen #667
Comments
A few other things I noticed during comparison: pre-release: https://jupyter-docker-stacks--1855.org.readthedocs.build/en/1855/using/recipes.html
|
this is super helpful, thanks! that's what we have pre-releases for :-) |
In the PR linked above I also fixed the header color change, there are a few others that we'll need to follow up on separately. Could you open issues for them?
|
I added two issues for the last 2 problems. Thanks for all the fixes, it looks much better now. |
I agree - I just cannot for the life of me figure out how to fix it :-D |
When you click an in-page link (e.g. an anchor link) the link target is partially blocked by the article header.
This is because we are over-riding the
header-height
here to be 0px:sphinx-book-theme/src/sphinx_book_theme/assets/styles/abstracts/_variables.scss
Line 39 in 8e08709
The pydata theme is setting
scroll-padding-top
to be relative to this height, which is why setting the height to 0 is causing this to overlap.The text was updated successfully, but these errors were encountered: