Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Discussion of Syntax Choices #6

Closed
mmcky opened this issue Aug 31, 2020 · 5 comments
Closed

[ENH] Discussion of Syntax Choices #6

mmcky opened this issue Aug 31, 2020 · 5 comments

Comments

@mmcky
Copy link
Member

mmcky commented Aug 31, 2020

@najuzilu @AakashGfude

I have noticed the syntax for algorithms (and a couple of other directives) are children of the proof directive entry point. I guess this is in effect showing that directives are all part of the proof extension.

Do you think this is the right syntax choice here?

Just wondering if we should also support more generic entry points (as well) such as algorithm:

```{algorithm} Title
<options>

Text
```

Introduce top-level directive names:

Pro:

  1. Easier to remember for authors if extension is included by default with jupyter-book for out of the box support

Con:

  1. A benefit of proof:algorithm is for compatibility with sphinxcontrib-proof
  2. possible namespace collisions with other packages with more generic names.
@AakashGfude
Copy link
Member

@mmcky is there any popular package out there which has these generic syntaxes which the authors might use? If not, then probably we can get away with it?

@jstac
Copy link
Member

jstac commented Aug 31, 2020

I'm happy with this as is --- as you say, it's compatible with sphinxcontrib-proof.

At some point we can reach out to those guys and see if there is the possibility of unification.

@najuzilu
Copy link
Member

Personally I have no preference. It would be incredibly easy to support both.

@jstac
Copy link
Member

jstac commented Aug 31, 2020

My vote is that we do the minimum to make this work nicely, avoiding changes unless a user requests them.

@mmcky
Copy link
Member Author

mmcky commented Sep 1, 2020

Great -- let's keep the syntax matching sphinxcontrib-proof then.

I think that is a good direction. While I find {proof:exercise} a bit of an odd syntax we can always add in an {exercise} directive later.

Thanks for comments everyone.

@mmcky mmcky closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants