Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] Errors are just logged in background #19

Open
doriancransac opened this issue Mar 24, 2016 · 4 comments
Open

[Client] Errors are just logged in background #19

doriancransac opened this issue Mar 24, 2016 · 4 comments
Assignees

Comments

@doriancransac
Copy link
Contributor

Should be presented to the user through the GUI

@jeromecomte
Copy link
Contributor

I've replaced all the system outputs by logging. Errors should yet at least be found in the logs. I would suggest that we close this issue and reopen it for the specific cases where we want them explicitly to be shown to the user. There's unfortunately no way to solve this in a generic way actually.

@doriancransac
Copy link
Contributor Author

Does it have to do with the implementation of the swing listener (I don't really understand why you can't just implement a pop-up)?

Otherwise, how about this : we dedicate a small area of the GUI to displaying information (INFO, WARNING, ERROR for example), like just a narrow horizontal frame at the bottom of the screen, and then we implement a sort of static queue/worker system, that takes care of displaying any error message, and you could write into that queue from anywhere in the code. I know it doesn't sound sexy but that would work right?

Either that or we just implement something cleaner from the get go in the JS client version.

@JSclient

@jeromecomte
Copy link
Contributor

Nothing to do with swing but with my own code that is sometimes catching exceptions and not re-throwing them :S

For this reason this issue has to be solve case by case. Only question is: do we open an issue for each case or use this issue for all the potential cases?

@doriancransac
Copy link
Contributor Author

We'll keep this issue open and address the problem either completely or we'll at least start with the most common problems that confuse the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants