Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lilly's Lasagna Leftovers: two small issues #842

Open
allaxandr opened this issue Dec 16, 2024 · 1 comment
Open

Lilly's Lasagna Leftovers: two small issues #842

allaxandr opened this issue Dec 16, 2024 · 1 comment

Comments

@allaxandr
Copy link

Issue 1. This is a learning exercise, so it has an Introduction devoted to lambda lists. In the Optional Parameters section, there is a line

(optional-parameters 5 nil 10) ; => (5 DEFAULT (:Z-WAS-SUPPLIED 10))

In fact, it should be:

(optional-parameters 5 nil 10) ; => (5 NIL (:Z-WAS-SUPPLIED 10))

That is, nil value for a parameter is not the same as not supplying a value for the parameter.

Additionally, it's worth adding to the Introduction a note about how to correctly skip a default parameter (well, it must be a keyword parameter for us to be able to do that).

Issue 2. This exercise continues another learning exercise: Lilly's Lasagna. Lilly's Lasagna Leftovers is meant to re-implement some functions from Lilly's Lasagna in a more sophisticated way. The design in Lilly's Lasagna was: expected-time-in-oven defines total cooking time; remaining-minutes-in-oven subtracts from it elapsed-time-in-oven to produce its result. In Lilly's Lasagna Leftovers, the total cooking time is calculated in a more sophisticated way, but the function that is required to be rewritten is remaining-minutes-in-oven (which doesn't have an elapsed-time-in-oven parameter now).

Imo, the preferable way of fixing this issue is to rewrite expected-time-in-oven rather than remaining-minutes-in-oven. Regarding the latter, one small change can be: the parameter elapsed-time-in-oven should now have a default value of 0.

Copy link

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

@verdammelt verdammelt reopened this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants