Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: make Slug validation consistent #593

Open
ee7 opened this issue May 10, 2022 · 1 comment
Open

types: make Slug validation consistent #593

ee7 opened this issue May 10, 2022 · 1 comment
Labels
kind: feature User-facing enhancement

Comments

@ee7
Copy link
Member

ee7 commented May 10, 2022 •
edited
Loading

Right now, a slug: Slug in configlet sync is guaranteed to be kebab case. But it isn't in configlet lint.

Follow-up from #564 (review)

This is technically a user-facing change, not just a refactoring, as configlet might complain earlier when a slug is not kebab case.
@ee7 ee7 mentioned this issue May 10, 2022
Open
@ee7 ee7 added the kind: feature User-facing enhancement label May 15, 2022
@ee7
Copy link
Member Author

ee7 commented Jul 1, 2022

We can also consider e.g.

type
  ConceptSlug* = distinct string
  ExerciseSlug* = distinct string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: feature User-facing enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ee7