Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Concept prerequisite cycle found in commit 1145c7 #1481

Closed
exercism-bot opened this issue Aug 19, 2021 · 4 comments
Closed

🤖 Concept prerequisite cycle found in commit 1145c7 #1481

exercism-bot opened this issue Aug 19, 2021 · 4 comments

Comments

@exercism-bot
Copy link
Contributor

We found a concept prerequisite cycle in the config.json file in commit 1145c7b.

Such a cycle occurs when Concept Exercise A teaches concept X and has concept Y as a prerequisite, whereas Concept Exercise B teaches concept Y and has concept X as a prerequisite. The cycle can also be indirect, in which case there are intermediate Concept Exercises involved.

These prerequisite cycles should be removed to have the track work properly on the website.

Please tag @exercism/maintainers-admin if you require more information.

@jmrunkle
Copy link
Contributor

@exercism/maintainers-admin - I would be most grateful if there was a clean way to identify this without having to manually trace it. This was also opened 25 days ago so I have no idea if the problem has already been fixed. I thought configlet lint was setup to detect this sort of thing now?

@iHiD
Copy link
Member

iHiD commented Sep 13, 2021

I thought configlet lint was setup to detect this sort of thing now?

I'm not sure if confliget does this yet, but the intention is that it is in confliglet not the website. The website guard is really a guard-of-last-resort, so the debugging info should really be at the configlet level.

@jmrunkle
Copy link
Contributor

Ah, I see it is on their radar but not yet implemented (at present):

There must not be any cycles between "exercises.concept[].concepts" and "exercises.concept[].prerequisites"

From exercism/configlet#249

@jmrunkle
Copy link
Contributor

I just did a manual read through every concept exercise stanza to confirm that every concept does not have a cycle through its prerequisites. I think this is working now, but frankly I will wait for configlet lint to complain if it is actually still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants