Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the-farm: introduce interfaces concept #1638

Closed
Tracked by #1640
ErikSchierboom opened this issue Sep 17, 2021 · 11 comments
Closed
Tracked by #1640

the-farm: introduce interfaces concept #1638

ErikSchierboom opened this issue Sep 17, 2021 · 11 comments
Assignees
Labels
x:status/claimed Someone is working on this issue

Comments

@ErikSchierboom
Copy link
Member

ErikSchierboom commented Sep 17, 2021

The Farm should unlock interfaces. This will involve:

  • Updating the exercise's instructions.md file
  • Updating the exercise's introduction.md
  • Updating the concept's introduction.md
  • Updating the concept's about.md file
  • Add interfaces to the concepts for the the-farm exercise in the config.json
@ErikSchierboom ErikSchierboom changed the title the-farm: consider function type the-farm: introduce interfaces concept Sep 17, 2021
@jmrunkle jmrunkle added the x:status/claimed Someone is working on this issue label Oct 3, 2021
@junedev junedev closed this as completed Oct 21, 2021
@junedev junedev reopened this Oct 21, 2021
@junedev
Copy link
Member

junedev commented Oct 21, 2021

@jmrunkle Do you want to continue to work on this and update the exercise to include the new concept or should we re-assign this task?

@jmrunkle
Copy link
Contributor

Yes, sorry for the delay. Give me a couple more days. If I cannot finish by then we can reassign.

@junedev
Copy link
Member

junedev commented Oct 30, 2021

@jmrunkle Could you give me an update whether I should unassign you or not?

@jmrunkle
Copy link
Contributor

jmrunkle commented Nov 6, 2021

Sorry, still recovering from new baby. I'm nearly done with this so if you do not mind being a little patient, I can finish it.

@junedev
Copy link
Member

junedev commented Nov 6, 2021

@jmrunkle I know how that feels 💙 and I would really like that you don't have this issue in your neck anymore. So if you don't mind, @andrerfcsantos offered to finish this up. If you could push whatever you have to some branch/ create a draft PR, he can pick it up from there.

@andrerfcsantos
Copy link
Member

@jmrunkle I don't mind waiting a bit more, but like June said, I'll happily finish this so you can have more time with your family!

@andrerfcsantos
Copy link
Member

@jmrunkle Can you give us an update on this?

@jmrunkle
Copy link
Contributor

jmrunkle commented Dec 2, 2021

I just turned my in-progress code into a draft PR: #1976

I have lost a bit of context on where exactly I had left this, but I will try to make it complete today.

@jmrunkle
Copy link
Contributor

jmrunkle commented Dec 2, 2021

Looks like the main thing that was missing was to copy the intro material about interfaces into the intro for the exercise. Let me patch that in and then send the PR out for review.

@junedev
Copy link
Member

junedev commented Dec 2, 2021

@jmrunkle To avoid further delays (students keep asking for this), I would suggest @andrerfcsantos can directly push small fixes to your branch if anything comes up instead of writing review comments and waiting for them to be resolved. This way it can be merged quickly. If you object, let us know.

@jmrunkle
Copy link
Contributor

jmrunkle commented Dec 3, 2021

Sounds fine to me. I don't mind either way

@junedev junedev closed this as completed Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:status/claimed Someone is working on this issue
Projects
None yet
Development

No branches or pull requests

4 participants