Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythagorean-triplet: optimise implementation #900

Closed
SleeplessByte opened this issue Dec 24, 2020 · 1 comment · Fixed by #1324
Closed

pythagorean-triplet: optimise implementation #900

SleeplessByte opened this issue Dec 24, 2020 · 1 comment · Fixed by #1324
Labels
enhancement 🦄 Changing current behaviour, enhancing what's already there good first issue

Comments

@SleeplessByte
Copy link
Member

Don't work on this issue until #895 is merged, or use that PR as a base branch.

The "large factors" test currently won't finish/complete. When fixed, replace test.skip with xtest.
@SleeplessByte SleeplessByte added enhancement 🦄 Changing current behaviour, enhancing what's already there good first issue labels Dec 24, 2020
@eakray
Copy link
Contributor

eakray commented Sep 7, 2021

Opened up a tiny PR for this (#1324).

@junedev junedev linked a pull request Sep 8, 2021 that will close this issue
reduced pythagorean-triplet's time complexity from cubic to quadratic #1324
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🦄 Changing current behaviour, enhancing what's already there good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reduced pythagorean-triplet's time complexity from cubic to quadratic eakray/javascript
2 participants
@SleeplessByte @eakray