Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #440

Closed
ErikSchierboom opened this issue Aug 24, 2021 · 5 comments
Closed

Fix CI #440

ErikSchierboom opened this issue Aug 24, 2021 · 5 comments
Labels
x:action/fix Fix an issue x:knowledge/intermediate Quite a bit of Exercism knowledge required x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)

Comments

@ErikSchierboom
Copy link
Member

This repository's main branch currently does not pass all CI checks.
This makes detecting issues in PRs harder and might result in a broken track, and so is an important thing to fix.

The following CI workflows are currently failing:

https://github.com/exercism/julia/runs/3339009172

Tracking

exercism/v3-launch#55

@ErikSchierboom ErikSchierboom added x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:knowledge/intermediate Quite a bit of Exercism knowledge required x:action/fix Fix an issue labels Aug 24, 2021
@serialhex
Copy link
Contributor

Hey @ErikSchierboom I've started working on this, and just had some comments/questions. This seems to be mostly configlet lint type stuff, so it seems pretty easy to resolve. I'm just not sure if you want me to split it into a couple of PR's or want one big one. There are a few things of note:

  1. 'leap' was both a practice exercise, and a concept. I thought it keeping the concept and removing the exercise would be the way to go. Although reversing that, and removing it as a concept but leaving the practice is valid, also renaming one. IDK, input would be nice.
  2. There are a whole series of files missing, mostly introduction.md for the various concepts. It looks like these concepts are stubs with no real information in them yet. Making empty files silences configlet, so that's what I'm doing now.
  3. authors under config.json is empty in a handful of cases (mostly the stubs that I mentioned before). Adding author information for each of these is simple if I just go based on git history: You & SaschaMann (mostly). Is simply using git history sufficient or should I remove you? (as you may-or-may-not have added anything, being owner of this repo, thus your name being added to everything that gets committed) Or is there something else that you would like me to do?

Any comments are greatly appreciated!

If you like, I can split these up into 3 (or maybe more) PR's so you can check them out & add them separately. I'm fine either way.

Take care!

@SaschaMann
Copy link
Contributor

SaschaMann commented Oct 12, 2021

Hi!

I thought it keeping the concept and removing the exercise would be the way to go.

There's an open PR for this: #365

Making empty files silences configlet, so that's what I'm doing now.

Please don't. Silencing configlet means those files will just be missed. They should either have proper content or not exist. The failure is desired behaviour.

@ErikSchierboom
Copy link
Member Author

@serialhex Thanks for wanting to contribute! @SaschaMann has the best overview of which things can actually be fixed and which things should remain errors, so I'll defer to @SaschaMann to help decide which linting errors can be fixed.

@SaschaMann
Copy link
Contributor

PRs that add content to the files that are reported missing are welcomed though, in case you want to fix the errors that way :)

@serialhex
Copy link
Contributor

I will probably add one that adds the authors to the authors array in config.json. Actually writing an introduction.md would be a bit much for me ATM, as I'm not that good of an expository writer IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/fix Fix an issue x:knowledge/intermediate Quite a bit of Exercism knowledge required x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)
Projects
None yet
Development

No branches or pull requests

3 participants