Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert exercise dependencies from core_kernel to base #277

Closed
4 tasks done
sshine opened this issue Sep 11, 2018 · 3 comments
Closed
4 tasks done

Convert exercise dependencies from core_kernel to base #277

sshine opened this issue Sep 11, 2018 · 3 comments
Assignees

Comments

@sshine
Copy link
Contributor

sshine commented Sep 11, 2018

Affected exercises:

  • meetup uses Date from Core_kernel and can't simply be downgraded, I think.
  • zipper uses nothing outside Base and can trivially be downgraded.
  • word-count uses String.Map from Core_kernel and can somewhat simply be downgraded.
  • nucleotide-count uses Char.Map from Core_kernel and can somewhat simply be downgraded.
  • react uses the deprecated succ instead of Int.succ and Int.Table (which looks like a specialized Hashtbl) can be downgraded with a bit of fiddling.

The remaining 40 exercises all depend on Base.

@stevejb71
Copy link
Contributor

Meetup could define its own date type.

@sshine
Copy link
Contributor Author

sshine commented Sep 23, 2018

Then the exercise would have to contain a function that converts a date to a weekday. I don't know if that's hard, but it's something I would like to expect is solved by a date library.

I would prefer if the exercise encouraged the use of existing popular libraries when ones exist.

I think this exercise belongs to Core_kernel unless there's another date module that is also popular.

@sshine
Copy link
Contributor Author

sshine commented Oct 9, 2018

I'll leave meetup as-is until a proposal to change it is made.

@sshine sshine closed this as completed Oct 9, 2018
This was referenced Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants