Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configlet-ci: consider adding configlet sync support #223

Open
ee7 opened this issue May 11, 2022 · 1 comment
Open

configlet-ci: consider adding configlet sync support #223

ee7 opened this issue May 11, 2022 · 1 comment

Comments

@ee7
Copy link
Member

ee7 commented May 11, 2022

Possibly configurable, like configlet fmt currently is.

We should do this in a way that makes the check optional - it shouldn't block a PR from being merged.
@SaschaMann
Copy link
Contributor

We should do this in a way that makes the check optional - it shouldn't block a PR from being merged.

This is a hard problem to solve right now. (actions/runner#2347) There are a few workarounds but they're all kinda hacky.

Some workarounds:

  • Post a comment in the PR
  • Create a new check and set it to pending as a warning (it'll show up yellow but not prevent merging)
  • Print an error or a warning but let the check pass anyway. Major downside: this is super easy to miss unless you go to the detailed build log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SaschaMann @ee7