Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bank-account: implement exercise #730

Closed
ilya-khadykin opened this issue Oct 6, 2017 · 12 comments
Closed

bank-account: implement exercise #730

ilya-khadykin opened this issue Oct 6, 2017 · 12 comments

Comments

@ilya-khadykin
Copy link
Contributor

There are exercises that are not yet implemented in Python track (the full list of them - #417 (comment)).
You can help us change this situation by implementing this one. Ref #417

The guide "Implement an exercise from specification" will help you succeed.

If you still have questions, I encourage you to ask them before starting working on the issue.

I also suggest claiming the issue by creating an empty PR as stated here

Please note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
This simple thing helps us a lot, and makes our life a bit easier

@thecouchcoder
Copy link
Contributor

I'd like to take a look at this one.

@ilya-khadykin
Copy link
Contributor Author

@aes421 that is awesome, good luck!

@thecouchcoder
Copy link
Contributor

Hey @m-a-ge I read up on rebasing. Do you want me to squash all my commits into one?

@ilya-khadykin
Copy link
Contributor Author

@aes421 that would be great.
There still some unwanted comments in your PR, could you get rid of them?

@thecouchcoder
Copy link
Contributor

@m-a-ge Did you mean unwanted commits?

@ilya-khadykin
Copy link
Contributor Author

The ones highlighted in yellow:
image

@thecouchcoder
Copy link
Contributor

@m-a-ge Got everything cleaned up. What should I do next to finish off the pull request?

@ilya-khadykin
Copy link
Contributor Author

@aes421 I (or someone else) will review it once again to make sure everything is Ok and merge it.
Might take some time considering amount of activity this month. I'll try to do it today

@thecouchcoder
Copy link
Contributor

No problem, I understand. Thanks!

@stale
Copy link

stale bot commented Nov 23, 2017

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mrcfps
Copy link

mrcfps commented Apr 6, 2018

@cmccandless This issue was resolved in #1260. Please close it.

@cmccandless
Copy link
Contributor

Closed in #1260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants