Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #476

Closed
ErikSchierboom opened this issue Aug 24, 2021 · 2 comments
Closed

Fix CI #476

ErikSchierboom opened this issue Aug 24, 2021 · 2 comments
Labels
x:action/fix Fix an issue x:knowledge/intermediate Quite a bit of Exercism knowledge required x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)

Comments

@ErikSchierboom
Copy link
Member

This repository's main branch currently does not pass all CI checks.
This makes detecting issues in PRs harder and might result in a broken track, and so is an important thing to fix.

The following CI workflows are currently failing:

https://github.com/exercism/swift/runs/3370849643

Tracking

exercism/v3-launch#55
@ErikSchierboom ErikSchierboom added x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:knowledge/intermediate Quite a bit of Exercism knowledge required x:action/fix Fix an issue labels Aug 24, 2021
@sanderploegsma
Copy link
Contributor

sanderploegsma commented Sep 29, 2021 •
edited
Loading

The CI job is fixed by #487 and the Configlet job is fixed by #484.

I don't know what the CircleCI job is still doing, since there is no .circleci/config.yml in the repo (anymore). Perhaps this integration is outdated after #398 and can be disabled?

@wsaults wsaults mentioned this issue Nov 23, 2021
Merged
@kerolloz
Copy link

@ErikSchierboom
Tests pass here
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
x:action/fix Fix an issue x:knowledge/intermediate Quite a bit of Exercism knowledge required x:size/medium Medium amount of work x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErikSchierboom @sanderploegsma @kerolloz