configlet fmt on deprecated exercises: Should not re-add core, unlocked_by, difficulty, topics

[petertseng]

recent configlet fmt adds these keys to all exercises in the deprecated array

+      "core": false,
+      "unlocked_by": null,
+      "difficulty": 0,
+      "topics": null,

In exercism/discussions#159 (comment) I argued that I saw no reason to keep difficulty and topics there. I continue to see no reason, however this is your chance to make me see a reason.

For example, perhaps any exercise that becomes deprecated could simply retain all its old values for these fields. And perhaps that is eminently useful, for some reason. That would certainly be cause for me to see a reason.

In such a case, please be advised that I'm not going to expend mental energy on making up values for exercises that were deprecated before this operation, so these values are going to remain whatever values configlet fmt decided to place for them (0 and null respectively), and I hope that's okay.

I also reject a workflow that manually removes these keys from deprecated exercises after having run configlet fmt because 1) why would any person want to do manual work 2) https://github.com/exercism/haskell/blob/master/bin/check-configlet-fmt.sh https://github.com/exercism/rust/blob/master/_test/check-configlet-fmt.sh would make Travis CI reject it anyway.

It may be possible to exclude those fields from the deprecated array only, but that would involve either keeping two structs in sync painstakingly, or some embedding, and I have not yet speculated on the clarity of the resulting structs. I cannot advise on this course of action.

If something else should happen, please advise.

[kytrinyx]

I continue to see no reason, however this is your chance to make me see a reason.

I agree with you. I had forgotten to add tests for this case.