Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esbuild steps with metafile output to README #27

Closed
yonta opened this issue May 24, 2024 · 5 comments · Fixed by #29
Closed

Add esbuild steps with metafile output to README #27

yonta opened this issue May 24, 2024 · 5 comments · Fixed by #29

Comments

@yonta
Copy link
Contributor

yonta commented May 24, 2024

I tried this repository and stumbled upon the need to output a metafile in the esbuild configuration.
I think it would be helpful to include this in the README.

@exoego
Copy link
Owner

exoego commented May 24, 2024

I think this part in README describes that.
Do you think it is not enough?
image

@yonta
Copy link
Contributor Author

yonta commented May 24, 2024

Oh.
Sorry, I am using esbuild v0.19 (< v0.20), so I skipped this sentence.
I need not to skip, but I didn't notice.

@yonta
Copy link
Contributor Author

yonta commented May 24, 2024

For example, how about splitting the usages steps in the README?

  1. Configure esbuild to output a metafile.
    • CLI version
    • JS version
  2. Write the GitHub Actions.

The CLI version is easier than the JS version, and I've also split the esbuild configuration steps.
What do you think?

@exoego
Copy link
Owner

exoego commented May 24, 2024

Added CLI version example, which I was not aware of, to README in #29

@yonta
Copy link
Contributor Author

yonta commented May 24, 2024

Thanks to update README🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants