Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: include_size_comparison not filtering correctly #87

Closed
Eirmas opened this issue Sep 2, 2024 · 2 comments
Closed

bug: include_size_comparison not filtering correctly #87

Eirmas opened this issue Sep 2, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Eirmas
Copy link

Eirmas commented Sep 2, 2024

include_size_comparison doesnt seem to be filtering like its supposed to.

I am using this config:

      - name: Analyze esbuild bundle size
        uses: exoego/esbuild-bundle-analyzer@v1
        with:
          metafiles: 'dist/apps/blend/stats.json'
          show_details: false
          include_size_comparison: 'total'
          top_n_largest_paths: 0
          show_no_change: false

With this config, we are not getting a total row, and it only shows Added / Deleted rows. It does seem to filter away No changes correctly.

@exoego
Copy link
Owner

exoego commented Sep 2, 2024

Thanks.
I'll take a look within a few days

@exoego
Copy link
Owner

exoego commented Sep 3, 2024

This is fixed in v1.5.2:

image

@exoego exoego closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants