Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Total shows wrong numbers #90

Closed
Eirmas opened this issue Sep 4, 2024 · 3 comments · Fixed by #91
Closed

bug: Total shows wrong numbers #90

Eirmas opened this issue Sep 4, 2024 · 3 comments · Fixed by #91
Labels
bug Something isn't working

Comments

@Eirmas
Copy link

Eirmas commented Sep 4, 2024

The total row seems to show the wrong diff percentage

The hidden bundles shows a bunch of "added" / "removed" lines. Could it be related to that?

image
@Eirmas
Copy link
Author

Eirmas commented Sep 4, 2024

For context, the PR in the picture did not introduce any changes to the bundle size, so the percentage should have been 0 because baseBundleSize === newBundleSize

@Eirmas
Copy link
Author

Eirmas commented Sep 5, 2024

image

@exoego exoego mentioned this issue Sep 8, 2024
Merged
@exoego exoego closed this as completed in #91 Sep 8, 2024
@exoego
Copy link
Owner

exoego commented Sep 8, 2024

I thinks this was fixed in v1.5.4

@exoego exoego added the bug Something isn't working label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: total size calculation exoego/esbuild-bundle-analyzer
2 participants
@exoego @Eirmas