-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: Implementing Kronecker terms #6
Conversation
OK - I added a numpy implementation of the low rank term and I think it's right... |
I've opened #8 to track the fact that we haven't implemented missing data yet, but I want to continue with this implementation without worrying about the details of that too much so I've removed that from the checklist. |
I took a stab at the conditional mean matrices and it wasn't obvious how to make it work so I'm also going to punt on that for now. |
I realized that there must be some way to convert Appendix C of the Celerite2D paper into the |
@tagordon @ericagol: In writing up the docs for this, I realized something that perhaps you guys have known all along. We've been artificially restricting ourselves with these two "cases" for the covariance. If we write: |
@dfm Nice; I hadn't realized this! |
@dfm I guess I hadn’t thought it through that far! That works out nicely. |
closes #5
To do:
LowRankKronTerm
get_celerite_matrices
implementation but I haven't worked it throughConsider interface to deal with missing data. Perhaps we just want to allowR
oralpha
to have an entry for each time? Or do we just want to have a mask for missing data? The former is more flexible, but the logic is a bit trickier and what would that mean for predictions? Nowalpha
andR
would have to be functions of time? I'm open to this being punted on and moved to future work.@tagordon: I'll add you as a collaborator on this repository shortly so that you can push to this branch.