Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pencil): Remove coverage from dist #9

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

neenhouse
Copy link
Contributor

Coverage data is being shipped with the transpiled lib

Description

Lib is shipped with extra information. Porting to jest allowed removing babel istanbul plugin

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@@ -3,7 +3,6 @@ module.exports = {
plugins: [
['@babel/plugin-proposal-class-properties', {loose: true}],
'@babel/plugin-transform-destructuring',
['@babel/plugin-proposal-object-rest-spread', {loose: true}],
'istanbul'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin was causing issues

@neenhouse neenhouse merged commit da74776 into master Mar 4, 2020
@neenhouse neenhouse deleted the remove-coverage-from-dist branch March 4, 2020 04:36
@neenhouse
Copy link
Contributor Author

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant