Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests>=2.13 requirements #1137

Closed
NicolasEhrhardt opened this issue Jun 16, 2017 · 3 comments
Closed

requests>=2.13 requirements #1137

NicolasEhrhardt opened this issue Jun 16, 2017 · 3 comments
Labels
install Installation issues third-party Third-party packages and services

Comments

@NicolasEhrhardt
Copy link

Hi!

Is there a reason why the requests package min version >=2.13?
I am asking this because a decent amount of large projects have ranges with a max version lower than 2.13 (docker-compose for instance).

Given that requests is only used for downloading models on github, it is probably ok to drop the min version much below the current version. This change would allow much easier integration with any large project that are usually lacking a little behind with package versions.

Thanks,
-Nicolas

@ines
Copy link
Member

ines commented Jun 18, 2017

Ah okay, that's good to know. To be honest, when we add new dependencies, we usually just take the latest(ish) version, i.e. the one we can confirm is definitely compatible, and then use the next major release as the max version.

Considering requests is a very standard dependency, and really only used by spaCy's CLI, it should be absolutely no problem to change that. From your perspective, what would be a good version range to ensure compatibility with the projects you're using?

@ines ines added install Installation issues third-party Third-party packages and services labels Jun 18, 2017
@NicolasEhrhardt
Copy link
Author

NicolasEhrhardt commented Jul 13, 2017

It seems like the docker-compose folks settled on 2.11.1 as lowest safest. Therefore I am going to suggest this version, which should enable folks to integrate spaCy more easily into their stacks.

@ines ines closed this as completed in de25bad Jul 22, 2017
@lock
Copy link

lock bot commented May 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
install Installation issues third-party Third-party packages and services
Projects
None yet
Development

No branches or pull requests

2 participants