-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requests>=2.13 requirements #1137
Comments
Ah okay, that's good to know. To be honest, when we add new dependencies, we usually just take the latest(ish) version, i.e. the one we can confirm is definitely compatible, and then use the next major release as the max version. Considering |
It seems like the |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hi!
Is there a reason why the
requests
package min version>=2.13
?I am asking this because a decent amount of large projects have ranges with a max version lower than 2.13 (
docker-compose
for instance).Given that requests is only used for downloading models on github, it is probably ok to drop the min version much below the current version. This change would allow much easier integration with any large project that are usually lacking a little behind with package versions.
Thanks,
-Nicolas
The text was updated successfully, but these errors were encountered: