Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.8 fails to build on py3.8 #13645

Open
markjm opened this issue Oct 1, 2024 · 1 comment
Open

v3.8 fails to build on py3.8 #13645

markjm opened this issue Oct 1, 2024 · 1 comment

Comments

@markjm
Copy link

markjm commented Oct 1, 2024

How to reproduce the behaviour

Hi!

in the most recent release, the setup_requires numpy version was updated to a version which is not published for py3.8
https://github.com/explosion/spaCy/blob/master/setup.cfg#L39

1.24 is the last version available for py3.8 https://endoflife.date/numpy#python-support

The current setup.cfg does list 3.8 as still supported https://github.com/explosion/spaCy/blob/master/setup.cfg#L21

If that is true, perhaps the <py3.9 tag here should be downgraded (leaving >3.9 updated)

p.s. i see #13624 which looks related

The only solution is to update your Python, or continue using the version of spaCy that's been working for you.

This is a totally reasonable answer, but if thats the case, perhaps it would be best to remove the advertised support for 3.8 in those classifiers (and any other relevant locations)

Thanks so much for the great project!

Your Environment

  • Operating System: U20
  • Python Version Used: py3.8
  • spaCy Version Used: 3.8
  • Environment Information:
@honnibal
Copy link
Member

honnibal commented Oct 1, 2024

Yes I messed up and didn't change the metadata to drop Python3.8, sorry. It's indeed not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants