Add lower_ property to Span class?

[bdewilde]

This is a feature request, not a bug. (Is there a better place to post re: enhancements?)

For convenience, it would be great to have a lower_ property on spans analogous to the lemma_ property. Looks like it would be a super straightforward change, maybe even just

cdef class Span:
    ...
    property lower_:
        def __get__(self):
            return ' '.join([t.lower_ for t in self]).strip()

Thanks in advance!

[honnibal]

Maybe! If so, we should support the other string methods too, right?

I think we should think more deeply about an ABC over Token, Span and Doc.

[bdewilde]

Agreed! I just didn't want to ask for more than I had immediate use for. :)

[bhargavvader]

I'd like to take a shot at this; any pointers?
If we're doing this, might as well add all the other string methods.

[honnibal]

Sorry for letting this slip --- adding the other string methods sounds good. Adding the help wanted tag here.

The file to change is https://github.com/explosion/spaCy/blob/master/spacy/tokens/span.pyx

Tests would go here: https://github.com/explosion/spaCy/blob/master/spacy/tests/spans/test_span.py

[ines]

Fixed in #883!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.