Wrong use of Optional[] in typing for config parameter in the Language class

[MichalMalyska]

By the definition: https://docs.python.org/3/library/typing.html#typing.Optional
it is meant to signify a Union[sth, None] however if you pass a config=None to the add_pipe method:

spaCy/spacy/language.py

Line 725 in d94ddd5

config: Optional[Dict[str, Any]] = SimpleFrozenDict(),

you will get an error downstream from here:

spaCy/spacy/language.py

Line 628 in d94ddd5

if not isinstance(config, dict):

Which page or section is this issue related to?

Code documentation in Language Pipeline
https://github.com/explosion/spaCy/blob/d94ddd568691cfa9d56b353173237afe1f328b43/spacy/language.py

[svlandeg]

You're right, the code does not allow this parameter to be Optional. Its optional in the sense that there's a default value, but the typing is wrong, we'll get that fixed. Thanks for the report!

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.