Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not force to use yarn #324

Closed
deadcoder0904 opened this issue Jul 22, 2017 · 6 comments
Closed

Do not force to use yarn #324

deadcoder0904 opened this issue Jul 22, 2017 · 6 comments

Comments

@deadcoder0904
Copy link
Contributor

Allow users to run the command rather than forcing 😃

I think people can type npm i or yarn after doing create-react-native-app myApp

My main concern is due to I want to use pnpm which is fast & saves a lotta disk space than both npm & yarn 😉

As a guy doing a lotta projects in react-native I don't think I need to waste space for more node_modules 😜

@brentvatne
Copy link
Member

As a guy doing a lotta projects in react-native I don't think I need to waste space for more node_modules 😜

lol

I think people can type npm i or yarn after doing create-react-native-app myApp

99% of the time you will be doing this, and this is the behavior of create-react-app, so we aren't going to change this. if you want to add a flag to disable it, then that would be fine! a PR is welcome for that.

@brentvatne
Copy link
Member

I forgot about this commit ;) 1609cef

you can specify --package-manager when running create-react-native-app if you want! will cut a release with this shortly

@deadcoder0904
Copy link
Contributor Author

Thanks !! I knew there must be some flag but couldn't figure it out 😂

@deadcoder0904
Copy link
Contributor Author

pnpm also supported #412

@vjpr
Copy link

vjpr commented Jan 26, 2018

I see this message following an install with pnpm.


ERROR: npm 5 is not supported yet


It looks like you're using npm 5 which was recently released.

Create React Native App doesn't work with npm 5 yet, unfortunately. We
recommend using npm 4 or yarn until some bugs are resolved.

You can follow the known issues with npm 5 at:
npm/npm#16991


According to #412 (comment) pnpm is not supported yet.

@deadcoder0904
Copy link
Contributor Author

@vjpr Got busy with other things so couldn't send a PR. Still I tried using pnpm with react-native init & it doesn't work because of this issue so I don't know if its worth the trouble yet. I'm currently using npm & yarn bcz sometimes pnpm has issues as it isn't matured yet for some of my usecases. I have filed an issue there so if it works out. I'll make sure to send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants