fix: maps utils invariants for collections containing undefined values #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
A map can have undefined values on purpose, which makes it hard to distinguish from an undefined result of
Map.get
(could do a Map.has and invariant on that, but it's unnecessary in these cases since these invariants were just for programmer confidence, not API correctness or soundness).How
Remove invariants.
Test Plan
Run tests (which test these extensively).