Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type generic default in test utils #104

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

wschurman
Copy link
Member

Why

b8e07f9 added the TID narrowing, but without the default value for TSelectedFields consumers would have to specify keyof TFields manually. All public APIs for entity should have the default, and internal APIs shouldn't need to specify it since they're fully qualified.

How

Add defaults.

Test Plan

yarn tsc

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #104 (c34174a) into master (29c1a43) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   94.95%   94.95%           
=======================================
  Files          66       66           
  Lines        1624     1624           
  Branches      195      195           
=======================================
  Hits         1542     1542           
  Misses         80       80           
  Partials        2        2           
Flag Coverage Δ
integration 94.95% <ø> (ø)
unittest 94.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ty/src/utils/testing/PrivacyPolicyRuleTestUtils.ts 90.90% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c1a43...c34174a. Read the comment docs.

@wschurman wschurman merged commit fe2917e into master Dec 24, 2020
@wschurman wschurman deleted the @wschurman/fix-type-specification branch December 24, 2020 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant