fix: use column name instead of field name for redis cache key #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Having the cache key on field name means that field renames need to bump the cache key for the entity itself, which is non-obvious (we've been bit by it twice at Expo). Instead, it makes more sense to cache keyed by column name which is much clearer that a cache key bump is needed when changed.
Closes #107.
Closes ENG-291.
How
Change to use column name in key generation function.
Note that upgrading to a version that includes this change will cause a full entity cache invalidation of all entities. This should be fine for most applications but was why we were hesitant to make this change previously. Now the benefits outweigh the costs though.
Test Plan
Run all tests.