Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade ioredis, knex, and pg #125

Merged
merged 1 commit into from
May 26, 2021

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented May 26, 2021

Why

It's good to be on recent versions of libraries for perf and security reasons. This PR updates three dependencies:

How

Upgrade packages, yarn tsc, run tests.

Test Plan

yarn tsc, run tests. yarn link into Expo www, run all tests there as well.

@wschurman wschurman requested a review from ide May 26, 2021 17:40
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #125 (71b1920) into master (4cba01e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          70       70           
  Lines        1772     1772           
  Branches      208      208           
=======================================
  Hits         1689     1689           
  Misses         81       81           
  Partials        2        2           
Flag Coverage Δ
integration 95.31% <100.00%> (ø)
unittest 95.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-adapter-knex/src/PostgresEntityDatabaseAdapter.ts 100.00% <ø> (ø)
...ter-knex/src/PostgresEntityQueryContextProvider.ts 100.00% <ø> (ø)
...-adapter-knex/src/errors/wrapNativePostgresCall.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cba01e...71b1920. Read the comment docs.

@wschurman wschurman requested a review from jkhales May 26, 2021 18:22
Copy link
Member

@ide ide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't totally understand the decisions the type declaration authors made for knex vs Knex (I get why they are separate but not why the two are both namespaces) but this commit looks fine.

@wschurman wschurman merged commit 7c43edf into master May 26, 2021
@wschurman wschurman deleted the @wschurman/upgrade-ioredis-knex branch May 26, 2021 20:59
@@ -5,7 +5,7 @@ import {
ViewerContext,
} from '@expo/entity';
import { enforceAsyncResult } from '@expo/results';
import Knex from 'knex';
import { knex, Knex } from 'knex';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wat! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants