Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lru-cache yarn workspace version resolution #168

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

wschurman
Copy link
Member

Why

lru-cache was resolving to 6.0.0 in the workspace root, which is what the sub-package cache-adapter-local-memory was using even though it required 7.x. I'm not sure why workspaces behaves this way, but the only way I could figure out how to fix it was to require 7.x in the root package.json.

I also looked into nohoist but it didn't seem to work as I would have expected: https://classic.yarnpkg.com/blog/2018/02/15/nohoist/.

How

Update base package.json.

Test Plan

Run all tests with new version, see it was failing until new argument formats were included.

@wschurman wschurman requested a review from quinlanj March 12, 2022 00:57
@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #168 (890bc86) into master (0736e20) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   96.09%   96.15%   +0.05%     
==========================================
  Files          80       80              
  Lines        1973     1975       +2     
  Branches      210      211       +1     
==========================================
+ Hits         1896     1899       +3     
+ Misses         76       75       -1     
  Partials        1        1              
Flag Coverage Δ
integration 96.15% <100.00%> (+0.05%) ⬆️
unittest 96.15% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...apter-local-memory/src/GenericLocalMemoryCacher.ts 100.00% <100.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0736e20...890bc86. Read the comment docs.

@wschurman wschurman merged commit e76ca8c into master Mar 12, 2022
@wschurman wschurman deleted the @wschurman/fix-lru-cache-version-resolution branch March 12, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant