fix: lru-cache yarn workspace version resolution #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
lru-cache
was resolving to 6.0.0 in the workspace root, which is what the sub-package cache-adapter-local-memory was using even though it required 7.x. I'm not sure why workspaces behaves this way, but the only way I could figure out how to fix it was to require 7.x in the root package.json.I also looked into
nohoist
but it didn't seem to work as I would have expected: https://classic.yarnpkg.com/blog/2018/02/15/nohoist/.How
Update base package.json.
Test Plan
Run all tests with new version, see it was failing until new argument formats were included.