feat: add EntityEdgeDeletionBehavior.SET_NULL_INVALIDATE_CACHE_ONLY #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
force-pushed
the
@wschurman/update-invalidate-only
branch
3 times, most recently
from
910e244 to
22f9f4a
Compare
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 96.17% 96.23% +0.06%
==========================================
Files 80 80
Lines 1985 1991 +6
Branches 257 263 +6
==========================================
+ Hits 1909 1916 +7
+ Misses 71 70 -1
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
wschurman
force-pushed
the
@wschurman/update-invalidate-only
branch
from
22f9f4a to
25cf6bb
Compare
ide
reviewed
Jul 14, 2022
| mutatorFactory | ||
| .forUpdate(inboundReferenceEntity, queryContext) | ||
| .setField(fieldName, null) | ||
| ['updateInTransactionAsync']( |
There was a problem hiding this comment.
Does type checking still work with the indexed accessor? Might be better to cast the type of setField's return value to an UpdateMutator.
There was a problem hiding this comment.
Yep, typechecking still works.
ide
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Previously it was recommended to use
EntityEdgeDeletionBehavior.CASCADE_DELETE_INVALIDATE_CACHEwhen the database was set up to doON DELETE SET NULL, but this had the bug where the deletion triggers would be run for the entity that was not actually being deleted by the DBMS (it was just being updated).The correct solution before this PR was to use
EntityEdgeDeletionBehavior.SET_NULLand rely upon entity to do the right thing.This PR introduces a new
EntityEdgeDeletionBehaviorfor theON DELETE SET NULLcase,EntityEdgeDeletionBehavior.SET_NULL_INVALIDATE_CACHE_ONLY, which runs the update triggers (and update cache invalidations) but rely upon the dbms for the actual underlying data update.How
Add new mode and tests.
Notes:
Test Plan
Run tests.