Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BigIntField #193

Merged
merged 2 commits into from
Sep 1, 2022
Merged

feat: add BigIntField #193

merged 2 commits into from
Sep 1, 2022

Conversation

wschurman
Copy link
Member

Why

Noticed by @FiberJW in https://github.com/expo/universe/pull/10420#discussion_r953010810. Knex (node-postgres) represents the BIGINT type as a string, so using IntField is incorrect.

How

This fixes that by adding a BigInt field that is of string type.

Test Plan

Run new test case.

@wschurman wschurman requested review from ide and FiberJW August 31, 2022 02:09
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #193 (31f03da) into main (8bdd9f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   96.29%   96.30%           
=======================================
  Files          80       81    +1     
  Lines        2024     2029    +5     
  Branches      269      269           
=======================================
+ Hits         1949     1954    +5     
  Misses         70       70           
  Partials        5        5           
Flag Coverage Δ
integration 96.30% <100.00%> (+<0.01%) ⬆️
unittest 96.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/entity/src/EntityFields.ts 100.00% <ø> (ø)
...s/entity-database-adapter-knex/src/EntityFields.ts 100.00% <100.00%> (ø)
...-adapter-knex/src/PostgresEntityDatabaseAdapter.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@FiberJW FiberJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for updating the library to support my GitHub integration work!

thumbs-up-00037

@wschurman wschurman merged commit acbad82 into main Sep 1, 2022
@wschurman wschurman deleted the @wschurman/bigint branch September 1, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants