Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused field from redis configuration #213

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

wschurman
Copy link
Member

Why

This was added in the initial commit ebe5ffd#diff-7060247da0b983e4354f340658d6c10fc547b357df02344a42921f6204399c22R19 but was never used. Only the cacheKeyVersion from each entity configuration is used.

In www we just put it in the prefix, which is sufficient and serves the same purpose:

const REDIS_CACHER_KEY_VERSION = 1;
const REDIS_CACHER_KEY_PREFIX = `v${REDIS_CACHER_KEY_VERSION}`;

How

Remove, tsc

Test Plan

CI

@wschurman wschurman requested review from ide and quinlanj June 10, 2023 00:02
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #213 (996a104) into main (3a00a43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files          79       79           
  Lines        2068     2068           
  Branches      279      279           
=======================================
  Hits         1976     1976           
  Misses         91       91           
  Partials        1        1           
Flag Coverage Δ
integration 95.55% <ø> (ø)
unittest 95.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tity-cache-adapter-redis/src/GenericRedisCacher.ts 100.00% <ø> (ø)

@wschurman wschurman merged commit 503a2fb into main Jun 10, 2023
@wschurman wschurman deleted the @wschurman/remove-unused-field branch June 10, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant