feat: add function to get authorization results for canViewerUpdateAsync/canViewerDeleteAsync #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 72 72
Lines 1964 1985 +21
Branches 276 275 -1
=========================================
+ Hits 1964 1985 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
…ync/canViewerDeleteAsync
wschurman
force-pushed
the
@wschurman/11-19-feat_add_function_to_get_authorization_results_for_canviewerupdateasync/canviewerdeleteasync
branch
from
c4dd3d5
to
2846c8a
Compare
quinlanj
approved these changes
Nov 20, 2024
wschurman
deleted the
@wschurman/11-19-feat_add_function_to_get_authorization_results_for_canviewerupdateasync/canviewerdeleteasync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There's a need to debug authorization failures at the callsites of
canViewerDeleteAsyncin Expo's server code. Making this return the authorization failure should help to debug.How
Add new set of functions that returns the result of the authorization check.
Test Plan
Add full test coverage for this new set of functions and run the tests.