Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix stub cache key generation for global cache #59

Merged
merged 1 commit into from
Jul 2, 2020

Conversation

wschurman
Copy link
Member

Why

4e40b2e#diff-7787fea5a7ed6c1892424d39f09dbc4aR51 added a companion-wide stub cache adapter to better simulate testing a real external cache adapter. Unfortunately, the cache key generation function for the stub cache adapter wasn't updated accordingly, so keys for entities from different tables could collide.

How

Use a more comprehensive cache key generation function.

Test Plan

yarn tsc

@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   94.07%   94.07%           
=======================================
  Files          58       58           
  Lines        1384     1384           
  Branches      147      147           
=======================================
  Hits         1302     1302           
  Misses         81       81           
  Partials        1        1           
Flag Coverage Δ
#integration 94.07% <100.00%> (ø)
#unittest 94.07% <100.00%> (ø)
Impacted Files Coverage Δ
...kages/entity/src/utils/testing/StubCacheAdapter.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa44e1...1e9d746. Read the comment docs.

@wschurman wschurman merged commit 7c180e8 into master Jul 2, 2020
@wschurman wschurman deleted the @wschurman/fix-stub-cache-key branch July 2, 2020 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant