fix: ensure transitive deletion triggers are run for CASCADE_DELETE_INVALIDATE_CACHE #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 94.55% 94.55%
=======================================
Files 59 59
Lines 1488 1488
Branches 165 167 +2
=======================================
Hits 1407 1407
Misses 79 79
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
ide
approved these changes
Jul 23, 2020
| private async deleteInTransactionAsync(): Promise<Result<void>> { | ||
| private async deleteInTransactionAsync( | ||
| processedEntityIdentifiersFromTransitiveDeletions: Set<string> = new Set(), | ||
| skipDatabaseDeletion: boolean = false |
There was a problem hiding this comment.
Could also write:
Suggested change
| skipDatabaseDeletion: boolean = false | |
| { skipDatabaseDeletion = false }: { skipDatabaseDeletion: boolean} = {} |
(yeah it's verbose but it's what we've got) This said I think the existing code is reasonable to read as-is.
There was a problem hiding this comment.
I'll probably leave it as-is. This makes me wonder how much effort goes into optimizing these one-off named param objects like this in v8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Before this PR, if a field was
CASCADE_DELETE_INVALIDATE_CACHEdeletion behavior it wouldn't run transitive triggers even though the underlying reference would be deleted by the database foreign key.This fixes that by doing all recursing through the delete method and just not deleting from the database if a boolean flag is specified. While I'm normally against boolean flags, because this is a private internal method I'm more okay with it.
Concretely the case this fixes is:
Entity A has field
b_idwith behavior CASCADE_DELETE_INVALIDATE_CACHE referencing an Entity B.Entity B has a trigger that runs during or after deletion (including afterCommit).
Previously B's triggers wouldn't be run. Now they are run.
Test Plan
Run tests. This is very extensively tested so the fact that no test changes were needed is reassuring.