-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: entity mutation validators #67
Conversation
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 94.55% 94.57% +0.02%
==========================================
Files 59 59
Lines 1488 1494 +6
Branches 165 166 +1
==========================================
+ Hits 1407 1413 +6
Misses 79 79
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably only want to run these on create and update, so that's what makes me think that there should probably just be one set of validators (see inline comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just add some test (as mentioned in summary) and convert the PR to non-draft and I'll review more thoroughly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before landing, update the summary (remove TODOs, detail behavior slightly more). Other than that, looks great. I'll probably rename EntityMutationTrigger
to something else in a follow-up PR.
Why
Implements validation for entity mutations. Validators are specified by the user, and run before every create and update mutation. Validators are run before any triggers.
#25
Tests