Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct type of runInTransactionAsync #81

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

wschurman
Copy link
Member

Why

Not sure why this wasn't an issue before but when upgraded to 0.7.0 this incorrect typing started showing up.

How

Fix the typing to be more specific so that methods within transaction blocks that typehint to require a transaction (only take an EntityTransactionalQueryContext instead of the superclass EntityQueryContext) don't fail to compile.

Test Plan

yarn tsc

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #81 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          60       60           
  Lines        1522     1522           
  Branches      181      181           
=======================================
  Hits         1440     1440           
  Misses         80       80           
  Partials        2        2           
Flag Coverage Δ
#integration ?
#unittest 94.61% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/entity/src/ReadonlyEntity.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b30cb...292b694. Read the comment docs.

@wschurman wschurman merged commit f98f7d1 into master Oct 1, 2020
@wschurman wschurman deleted the @wschurman/fix-method-typing branch October 1, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant