Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@expo/webpack-config should be looking in argv for mode, not env #19

Open
dancrumb opened this issue Aug 22, 2023 · 0 comments
Open

@expo/webpack-config should be looking in argv for mode, not env #19

dancrumb opened this issue Aug 22, 2023 · 0 comments

Comments

@dancrumb
Copy link

Summary

Per the Webpack 5 documentation, https://webpack.js.org/configuration/configuration-types/#exporting-a-function the mode property belongs on the argv object, not the env object.

While Expo itself may incorporate the non-standard approach of putting mode into env other tooling that interprets Webpack configuration files follow the API documentation, resulting in env validation failing.

Environment

N/A

Please specify your device/emulator/simulator platform, model and version

N/A

Error output

Error: @expo/webpack-config requires a valid mode string which should be one of: development, production, none

Reproducible demo or steps to reproduce from a blank project

Just run webpack without the env mode=development

@byCedric byCedric transferred this issue from expo/expo-cli Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant