Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feather icon set is deprecated and buggy, we probably need to switch to its successor is Lucide #19497

Closed
Noitidart opened this issue Oct 11, 2022 · 3 comments
Labels
pending closure awaiting final response before closing

Comments

@Noitidart
Copy link
Contributor

Noitidart commented Oct 11, 2022

Summary

I'm not sure if this is bug or feature request. But Feather icons is deprecated end of life, many requests to fix bugs, etc are falling flat. To fix the bugs with the feather icon set (like not showing right depending on DPI of phone), we may not want outdated things in expo and instead uses it successor.

These mention successor is Lucide - https://github.com/lucide-icons/lucide

What platform(s) does this occur on?

Android, iOS, Web

Environment

All environments.

Minimal reproducible example

One of the many bugs with Feather is seen here - https://icons.expo.fyi/Feather/chrome - with high DPI you will see glitches -
image

The correct way it should render is - seen on Lucide - https://lucide.dev/?search=chrome

image

@Noitidart Noitidart added the needs validation Issue needs to be validated label Oct 11, 2022
@Noitidart Noitidart changed the title Feather icon set is deprecated, we probably need to switch to its successor is Lucide Feather icon set is deprecated and buggy, we probably need to switch to its successor is Lucide Oct 11, 2022
@Simek
Copy link
Collaborator

Simek commented Nov 8, 2022

Hello @Noitidart,

@expo/vector-icons is only a compatibility wrapper around react-native-vector-icons package, we do not control the source.

Any feature requests or bug reports related to the content should be reported directly in react-native-vector-icons repository.

@Simek Simek added pending closure awaiting final response before closing and removed needs validation Issue needs to be validated labels Nov 8, 2022
@Noitidart
Copy link
Contributor Author

Noitidart commented Nov 8, 2022

Ah got it, thank you. I will create ticket now over there.

Edit: Here it is - oblador/react-native-vector-icons#1470

@Simek
Copy link
Collaborator

Simek commented Nov 8, 2022

Thank you for the follow up! 👍

@Simek Simek closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending closure awaiting final response before closing
Projects
None yet
Development

No branches or pull requests

2 participants