Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QS as it vulnerable #229

Closed
Delagen opened this issue Mar 6, 2017 · 8 comments · May be fixed by sigmacomputing/body-parser#1 or clevyr/body-parser#4
Closed

Update QS as it vulnerable #229

Delagen opened this issue Mar 6, 2017 · 8 comments · May be fixed by sigmacomputing/body-parser#1 or clevyr/body-parser#4
Assignees
Labels

Comments

@Delagen
Copy link

Delagen commented Mar 6, 2017

https://snyk.io/vuln/npm:qs:20170213

@dougwilson
Copy link
Contributor

We don't use the part of the qs module that has the vulnerability, so it is not necessary to update for any protection. We will however release an update regardless.

@dougwilson
Copy link
Contributor

I thought I released this last week, but from that link:

March 6th, 2017 - Final fix released in version 6.4.0.

What the fuck. It's basically impossible not to play release a new version with an updated qs game.

@Delagen
Copy link
Author

Delagen commented Mar 6, 2017

We don't use the part of the qs module that has the vulnerability, so it is not necessary to update for any protection. We will however release an update regardless.

May use another module with more specific functionality?

@dougwilson
Copy link
Contributor

If you know one, please let me know and I'd be happy to switch :) I'm not aware of any so we will completely drop the qs module and thus extended urlencoded parsing in 2.0

@dougwilson dougwilson self-assigned this Mar 6, 2017
@dougwilson dougwilson added the deps label Mar 6, 2017
@dougwilson
Copy link
Contributor

haha, of course Coveralls.io decides to change the way it reports coverage...

@dougwilson
Copy link
Contributor

Published to npm as 1.17.1

@Delagen
Copy link
Author

Delagen commented Mar 6, 2017

Express also related to this module, updated to 4.15.2. Thanks.

@dougwilson
Copy link
Contributor

No problem. Express is also not actually affected either, as it also does not use the vulnerable functionality from Qs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants